The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		May 3, 2026 3:31am

PR Summary

Medium Risk
Touches credential deletion paths and performs cross-table JSON updates to clear references before deletes; mistakes could lead to unintended data mutations or missed cleanup, but scope is limited to credential lifecycle flows.

Overview
Centralizes credential deletion into lib/credentials/deletion.ts, which clears stored credential references across workflow editor state (workflow_blocks), deployment versions, paused executions, checkpoints, and knowledge connectors before deleting the credential row and recording a deletion audit entry.

Updates the OAuth disconnect route and the credential DELETE API (plus the Copilot manage-credential delete tool) to use deleteCredential, ensuring credentials are removed before deleting related account rows to avoid FK cascade leaving stale JSON references.

Adds audit coverage for the OAuth credential lifecycle by recording CREDENTIAL_CREATED on draft-based creation and introducing a new CREDENTIAL_RECONNECTED action during reconnects; also expands CREDENTIAL_SUBBLOCK_IDS to include manualCredential and adds unit tests for the recursive reference-clearing walker.

^{Reviewed by Cursor Bugbot for commit cb1efeb. Configure here.}

Greptile Summary

This PR centralizes credential deletion into a new lib/credentials/deletion.ts helper that clears stored refs across workflow blocks, deployment versions, paused executions, checkpoints, and knowledge connectors before removing the credential row — preventing silent FK-cascade orphaning. It also wires in CREDENTIAL_CREATED / CREDENTIAL_RECONNECTED audit actions and extends CREDENTIAL_SUBBLOCK_IDS to cover manualCredential. The approach is idempotent and consistent across all three deletion call-sites (OAuth disconnect, explicit DELETE route, copilot tool).

Confidence Score: 5/5

Safe to merge — all findings are P2 (performance/observability) with no correctness or security defects.

No P0 or P1 issues found. The deletion logic is idempotent, authorization is verified at every call site before deleteCredential is invoked, and the recursive walker is thoroughly unit-tested. The two P2 comments are minor performance and audit-completeness suggestions.

No files require special attention.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant C as Caller (disconnect / DELETE / copilot)
    participant D as deleteCredential()
    participant DB as Database

    C->>+D: deleteCredential({ credentialId, actorId, reason })
    D->>DB: SELECT credential WHERE id = credentialId
    DB-->>D: row (workspaceId, type, displayName, ...)
    D->>+DB: Promise.all clearCredentialRefs(credentialId, workspaceId)
    Note over DB: 5 parallel passes
    DB-->>-D: workflow_blocks, deployment_versions, paused_executions, checkpoints, knowledge_connectors updated
    D->>DB: DELETE credential WHERE id = credentialId
    DB-->>D: ok
    D--)C: recordAudit(CREDENTIAL_DELETED) [fire-and-forget]
    D-->>-C: void

_{Reviews (2): Last reviewed commit: "improvement(credentials): parallelize in..." | Re-trigger Greptile}

@greptile

@cursor review